D13493: Auto-copy shared image link to clipboard

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  LGTM, just a comment to keep the commit history spotless ;)

INLINE COMMENTS

> KSMainWindow.cpp:268
>      hide();
> +    mMessageWidget->hide();
>      emit newScreenshotRequest(mode, timeout, includePointer, includeDecorations);

That's a nice and simple solution!

Would it make sense to split that out in a separate commit (no need for a Diff), and reference e9218fddfabd <https://phabricator.kde.org/R166:e9218fddfabd850f0878e03678af91f685c8969d> in the commit message? That's where `MessageDuration::Persistent` was introduced, which is not really specific to shared image links.

REPOSITORY
  R166 Spectacle

BRANCH
  auto-copy-link-to-clipboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13493

To: ngraham, #spectacle, #kde_applications, rkflx
Cc: kde-doc-english, rkflx, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20180619/61db6b17/attachment.html>