<table><tr><td style="">rkflx accepted this revision.<br />rkflx added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13493">View Revision</a></tr></table><br /><div><div><p>LGTM, just a comment to keep the commit history spotless ;)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13493#inline-71185">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KSMainWindow.cpp:268</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">hide</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">mMessageWidget</span><span style="color: #aa2211">-></span><span class="n">hide</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">emit</span> <span style="color: #004012">newScreenshotRequest</span><span class="p">(</span><span class="n">mode</span><span class="p">,</span> <span class="n">timeout</span><span class="p">,</span> <span class="n">includePointer</span><span class="p">,</span> <span class="n">includeDecorations</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's a nice and simple solution!</p>

<p style="padding: 0; margin: 8px;">Would it make sense to split that out in a separate commit (no need for a Diff), and reference <a href="https://phabricator.kde.org/R166:e9218fddfabd850f0878e03678af91f685c8969d" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">e9218fddfabd</a> in the commit message? That's where <tt style="background: #ebebeb; font-size: 13px;">MessageDuration::Persistent</tt> was introduced, which is not really specific to shared image links.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R166 Spectacle</div></div></div><br /><div><strong>BRANCH</strong><div><div>auto-copy-link-to-clipboard (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13493">https://phabricator.kde.org/D13493</a></div></div><br /><div><strong>To: </strong>ngraham, Spectacle, KDE Applications, rkflx<br /><strong>Cc: </strong>kde-doc-english, rkflx, skadinna<br /></div>