Flathub and Snap Store entries for KGeoTag

[Carl Schwan]

On Tuesday, January 2, 2024 10:50:07 PM CET Tobias Leupold wrote:
> Hi all!
> 
> As far as I can grasp it, https://apps.kde.org/de/kgeotag/ is automatically
> generated from KGeoTag's appdata.xml file. However, the site lists both
> Flathub and the Snapcraft as a possible installation source for KGeoTag,
> with "KDE" referenced as the publisher on both sites. I never used neither,
> so I don't know much about this besides those two are approaches to provide
> distribution independent packages, without relying on the respective
> package manager.
> 
> But what this is about:
> 
> On Flathub, one can read "No changelog provided" and "Proprietary: This app
> is not developed in the open, so only its developers know how it works. It
> may be insecure in ways that are hard to detect, and it may change without
> oversight."
> 
> Obviously, neither is true ...

No changelog provided is true. You don't have any changelog in your 
appdata.xml, you can look at how we do this in NeoChat
https://invent.kde.org/network/neochat/-/blob/master/
org.kde.neochat.appdata.xml?ref_type=heads#L407

Generally I recommend to follow the quality guidelines of Flathub
https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/quality-guidelines/

For the proprietary part, I asked in the flatpak matrix channel and this is 
probably an issue with appstream-glib used by gnome software and flathub and 
that doesn't recognize LicenseRef-KDE-Accepted-GPL in your appdata.xml. 
Discover actually has the same issue...

I'm not sure we need to add the LicenseRef in the appstream file is actually 
needed. For the user it's interesting that the project is licensed under gpl 3 
not that it could also potentially be licensed under gpl 4 in the future. This 
is an information only needed in your source code, I would say but INAL ;)

> 
> On Snapcraft, there's a similar "License: unset".

This is afaik not taken from the appstream file and doesn't affect only KGeoTag, 
the way I got this resolved in the past is to ask Jonathan to fix it ;)

> How can this be fixed? Is there something I can do about this? By adding
> something to the invent repo? Or somewhere else?
> 
> Thanks for all help!

I hope this helps :)
Cheers,

Carl
> 
> Cheers, Tobias