Incubation Request: Kiview

Sune Vuorela nospam at vuorela.dk
Mon Apr 29 08:21:03 BST 2024


On 2024-04-28, Méven <meven29 at gmail.com> wrote:
> The immediate goal with this application is to fill this request feature
> for dolphin :
> https://bugs.kde.org/show_bug.cgi?id=272539
> And we can imagine reusing it in many other places potentially.

I just opened 'DocumentViewer' class and spent 5 minutes and got a bit
scared.

"instant" preview?

Launching a background libreoffice?
Doing weird command line parsing of libreoffice? and bash pipe grep ?
Then throwing a generated pdf at qtwebengine and hoping the best?

There is a lot of std::tsring to qstring and back again conversions

There are plenty of std::string deepcopies.

Who deletes ConversionThread ?

If this class is in any way representative of the code quality of the
app, I really think we should reconsider.

If this class is not representative, then it definitely should be
architecturally re-done.

/Sune



More information about the kde-devel mailing list