Proposal: make squash-merging the default behavior for gitlab MRs

Ben Cooksley bcooksley at kde.org
Wed Oct 7 09:37:13 BST 2020


On Wed, Oct 7, 2020 at 9:33 PM David Hurka <david.hurka at mailbox.org> wrote:

> On Wednesday, October 7, 2020 9:52:41 AM CEST Ben Cooksley wrote:
> > > Isn’t it true that “Allow contributions” must be checked before the
> > > “Squash
> > > commits” checkbox is available? (I already wrote that, but I feel
> people
> > > don’t
> > > care, so I make it a question now.)
> >
> > The allow contributions box should always be ticked - we have
> > infrastructure components that automatically change this in the
> background
> > whenever a merge request is created.
>
> Oh, nice! This is from a MR from June 2020, which couldn’t be rebased:
>
> > You need to force push since you're rewriting history.
> >
> > If that doesn't work it means the branch author manually unchecked
> > the checkbox that enables collaboration and indeed there's not much
> > we can do other than creating a new branch/MR somewhere else.
>
> (https://invent.kde.org/graphics/okular/-/merge_requests/195#note_103948)
>
> Is the mentioned infrastructure component newer than that? Then it
> probably
> works fine. :)
>


>

I've taken a look and it appears that the review in question does have the
"Allow Collaboration" box ticked, so you should have been able to rebase it.
Unfortunately it has since been closed, so we can't investigate any further
unfortunately...

Cheers,
Ben
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-devel/attachments/20201007/173b9311/attachment-0001.htm>


More information about the kde-devel mailing list