How do you deal with incomplete commits?

[Thomas Friedrichsmeier]

Am Sun, 01 Nov 2020 09:52:27 -0800
schrieb Thiago Macieira <thiago at kde.org>:
> On Saturday, 31 October 2020 08:25:40 PST Thomas Friedrichsmeier
> wrote:
> > thanks for your answer (also to Nate). But to clarify, my question
> > is really: How do I _force_ myself to clean up in time?  
> 
> If you're pushing to a code review system of any kind, it doesn't
> matter. First, you should always review what you've sent for review
> anyway and you can notice you pushed something incomplete. At that
> point don't create the review request or write that it isn't yet
> ready for review.
> 
> Second, your reviewers should notice it's incomplete and won't
> approve.

Well, the context that I'm worrying about, here, is one where reviews
are not mandatory and not the norm.

I ended up writing a local pre-commit hook, which has the advantage of
triggering on the commit directly after "the problem commit", thus
increasing the likelihood there is still a trivial way to sort
things out.

(For good measure I also activated the pre-push hook as mentioned by
Nicolas.)

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://mail.kde.org/pipermail/kde-devel/attachments/20201102/5b93689b/attachment.sig>