KSvg in kdereview

[Ben Cooksley]

On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter <sitter at kde.org> wrote:

> LGTM now +2
>
> On Wed, Jun 21, 2023 at 10:04 AM Marco Martin <notmart at gmail.com> wrote:
> >
> > I fixed CI, passes now
>

Thanks for correcting that.

As Friedrich raised the initial concerns it would be nice to have him
confirm that the code quality issues he found have all been corrected.
Note that having something step into Frameworks is a big deal, so this is
something that should not be rushed and if there are issues with the code
we should fix them sooner vs. later.

Thanks,
Ben


> >
> > On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley <bcooksley at kde.org> wrote:
> > >
> > > Hi all,
> > >
> > > Sysadmin has just received a request to move this repository to
> Frameworks, however after seeing some of the comments raised here regarding
> the repository I took a look myself to see if they had been corrected.
> > >
> > > At this time CI is still broken in KSvg, for both platforms -
> something that was mentioned in an earlier email here.
> > > This does not inspire confidence that the code is up to scratch.
> > >
> > > I've therefore declined to move it to Frameworks at this time.
> > >
> > > Would be appreciated, given this is looking to be promoted to
> Frameworks, if people could please have a further look at this repository
> and comment as appropriate.
> > >
> > > Thanks,
> > > Ben
> > >
> > > On Wed, Jun 14, 2023 at 9:12 PM Marco Martin <notmart at gmail.com>
> wrote:
> > >>
> > >> Hi all,
> > >> Some time has passes, and changes have been done in the repo to
> > >> address some of the points.
> > >> Now there are review requests in plasma-framework which depends on
> > >> this repo (and accompanying plasma-workspace, plasma-desktop etc)
> > >> It would probably be better to have this in frameworks to have the
> > >> rest depending from it?
> > >>
> > >> On Thu, Apr 20, 2023 at 10:25 AM Marco Martin <notmart at gmail.com>
> wrote:
> > >> >
> > >> > Hi all,
> > >> > A part of plasma-framewrok, which is the one to do SVG-based themes,
> > >> > has now been splitted in a standalone library which is intended to
> be
> > >> > a new framework in KF6 (all usages of the plasma-framework version
> > >> > will be ported once this officially lands, and then those classes
> will
> > >> > be removed)
> > >> > The repo for now lives in
> > >> > https://invent.kde.org/libraries/plasmasvg
> > >> >
> > >> > In the end it will be renamed in ksvg
> > >> >
> > >> > Comments? reviews?
> > >> >
> > >> >
> > >> > --
> > >> > Marco Martin
> > >>
> > >> --
> > >> Marco Martin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20230621/56921244/attachment.htm>