<div dir="ltr"><div>On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter <<a href="mailto:sitter@kde.org">sitter@kde.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">LGTM now +2<br>
<br>
On Wed, Jun 21, 2023 at 10:04 AM Marco Martin <<a href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>> wrote:<br>
><br>
> I fixed CI, passes now<br></blockquote><div><br></div><div>Thanks for correcting that.</div><div><br></div>As Friedrich raised the initial concerns it would be nice to have him confirm that the code quality issues he found have all been corrected.</div><div class="gmail_quote">Note that having something step into Frameworks is a big deal, so this is something that should not be rushed and if there are issues with the code we should fix them sooner vs. later.</div><div class="gmail_quote"><br></div><div class="gmail_quote">Thanks,</div><div class="gmail_quote">Ben<br><div>Â </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
><br>
> On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley <<a href="mailto:bcooksley@kde.org" target="_blank">bcooksley@kde.org</a>> wrote:<br>
> ><br>
> > Hi all,<br>
> ><br>
> > Sysadmin has just received a request to move this repository to Frameworks, however after seeing some of the comments raised here regarding the repository I took a look myself to see if they had been corrected.<br>
> ><br>
> > At this time CI is still broken in KSvg, for both platforms - something that was mentioned in an earlier email here.<br>
> > This does not inspire confidence that the code is up to scratch.<br>
> ><br>
> > I've therefore declined to move it to Frameworks at this time.<br>
> ><br>
> > Would be appreciated, given this is looking to be promoted to Frameworks, if people could please have a further look at this repository and comment as appropriate.<br>
> ><br>
> > Thanks,<br>
> > Ben<br>
> ><br>
> > On Wed, Jun 14, 2023 at 9:12 PM Marco Martin <<a href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>> wrote:<br>
> >><br>
> >> Hi all,<br>
> >> Some time has passes, and changes have been done in the repo to<br>
> >> address some of the points.<br>
> >> Now there are review requests in plasma-framework which depends on<br>
> >> this repo (and accompanying plasma-workspace, plasma-desktop etc)<br>
> >> It would probably be better to have this in frameworks to have the<br>
> >> rest depending from it?<br>
> >><br>
> >> On Thu, Apr 20, 2023 at 10:25 AM Marco Martin <<a href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>> wrote:<br>
> >> ><br>
> >> > Hi all,<br>
> >> > A part of plasma-framewrok, which is the one to do SVG-based themes,<br>
> >> > has now been splitted in a standalone library which is intended to be<br>
> >> > a new framework in KF6 (all usages of the plasma-framework version<br>
> >> > will be ported once this officially lands, and then those classes will<br>
> >> > be removed)<br>
> >> > The repo for now lives in<br>
> >> > <a href="https://invent.kde.org/libraries/plasmasvg" rel="noreferrer" target="_blank">https://invent.kde.org/libraries/plasmasvg</a><br>
> >> ><br>
> >> > In the end it will be renamed in ksvg<br>
> >> ><br>
> >> > Comments? reviews?<br>
> >> ><br>
> >> ><br>
> >> > --<br>
> >> > Marco Martin<br>
> >><br>
> >> --<br>
> >> Marco Martin<br>
</blockquote></div></div>