Plasma Welcome Center on KDEReview

[Nate Graham]

On 9/17/22 02:16, Albert Astals Cid wrote:
> Understanding that this is a standalone app and none of its contents are
> reused to be shown in other apps a
>    KLocalizedString::setApplicationDomain("welcomecenter");
> call in its main.cpp will do.
> 
> Sidenote, given the name of the app is plasma-welcome i'd really suggest
> changing the catalog name to plasma-welcome too instead of welcomecenter.

Done.


> It's a kirigami app, sadly this means it has too many warnings
> https://pst.klgrth.io/paste/ydbmz

A few of those are already fixed in git master. For the others, I've 
tried to clean this up a bit by fixing warnings where I can, or at least 
filing bug reports:
- https://invent.kde.org/frameworks/kirigami/-/merge_requests/748
- https://invent.kde.org/network/kaccounts-integration/-/merge_requests/42
https://invent.kde.org/plasma/welcome-app/-/merge_requests/8
- https://bugs.kde.org/show_bug.cgi?id=459283
- https://bugs.kde.org/show_bug.cgi?id=459284


> When run on my computer i can't see any buttons on the top "toolbar" (they
> are there since generally clicking where they should be gets the thing to
> go next/ prev). What dependency version are you interested in knowing
> that may be causing this?

This is weird. I don't understand how the toolbar can be invisible but 
interactive for you. I'm at a loss here. Does anyone else have any ideas?


Nate