New repo in kdereview: KWeather

[Devin]

> Only nitpick I found as a user was that it's a bit weird that Settings -> About changes the main window instead of showing about data in the little settings window. I would suggest making About be one of the buttons on the main window, or showing the about data in the settings window.

I guess I can make the about page a popup as well, thanks!

Regards,
Devin

On Wed, Nov 9, 2022 at 5:37 PM Jeremy Whiting <jpwhiting at kde.org> wrote:
>
> After installing kirigami-addons it runs fine, adding my location went smooth, etc. Only nitpick I found as a user was that it's a bit weird that Settings -> About changes the main window instead of showing about data in the little settings window. I would suggest making About be one of the buttons on the main window, or showing the about data in the settings window.
>
> On Wed, Nov 9, 2022 at 3:31 PM Jeremy Whiting <jeremypwhiting at gmail.com> wrote:
>>
>> Looks like it's got a runtime dependency on kirigami (Maybe that's expected for plasma-mobile, not sure)
>>
>> Built it on laptop and got this from cmake:
>>
>> cmake ..
>> -- The C compiler identification is GNU 12.2.0
>> -- The CXX compiler identification is GNU 12.2.0
>> -- Detecting C compiler ABI info
>> -- Detecting C compiler ABI info - done
>> -- Check for working C compiler: /usr/bin/cc - skipped
>> -- Detecting C compile features
>> -- Detecting C compile features - done
>> -- Detecting CXX compiler ABI info
>> -- Detecting CXX compiler ABI info - done
>> -- Check for working CXX compiler: /usr/bin/c++ - skipped
>> -- Detecting CXX compile features
>> -- Detecting CXX compile features - done
>> -- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found components: Interpreter
>> -- Could NOT find ReuseTool (missing: REUSETOOL_EXECUTABLE)
>> CMake Warning at /usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86 (message):
>>  Reuse tool not found, skipping test generation
>> Call Stack (most recent call first):
>>  CMakeLists.txt:30 (include)
>>
>>
>> -- Skipping execution of outbound license tests.
>> -- Installing in the same prefix as Qt, adopting their path scheme.
>> -- Setting build type to 'Debug' as none was specified.
>> -- Looking for __GLIBC__
>> -- Looking for __GLIBC__ - found
>> -- Performing Test _OFFT_IS_64BIT
>> -- Performing Test _OFFT_IS_64BIT - Success
>> -- Performing Test HAVE_DATE_TIME
>> -- Performing Test HAVE_DATE_TIME - Success
>> -- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.99.0")
>> -- Found KF5Kirigami2: /usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.99.0")
>> -- Found Gettext: /usr/bin/msgmerge (found version "0.21.1")
>> -- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.99.0")
>> -- Found KF5CoreAddons: /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.99.0")
>> -- Found KF5Notifications: /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.99.0")
>> -- Found KF5: success (found suitable version "5.99.0", minimum required is "5.90.0") found components: Config Kirigami2 I18n CoreAddons Notifications
>> -- Found X11: /usr/include
>> -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so
>> -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - found
>> -- Looking for gethostbyname
>> -- Looking for gethostbyname - found
>> -- Looking for connect
>> -- Looking for connect - found
>> -- Looking for remove
>> -- Looking for remove - found
>> -- Looking for shmat
>> -- Looking for shmat - found
>> -- Looking for IceConnectionNumber in ICE
>> -- Looking for IceConnectionNumber in ICE - found
>> -- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.99.0")
>> -- Found KF5: success (found suitable version "5.99.0", minimum required is "5.90.0") found components: Plasma
>> -- Found org.kde.kholidays-QMLModule: TRUE (found version "")
>> -- The following RUNTIME packages have been found:
>>
>> * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a runtime dependency.
>>
>> -- The following OPTIONAL packages have been found:
>>
>> * Python3
>>   Required to run tests of module ECMCheckOutboundLicense
>> * Qt5QuickCompiler
>> * KF5Package (required version >= 5.99.0)
>> * KF5Service (required version >= 5.99.0)
>> * Freetype
>> * PkgConfig
>> * Fontconfig
>>
>> -- The following REQUIRED packages have been found:
>>
>> * ECM (required version >= 5.90.0)
>> * Qt5Network (required version >= 5.15.7)
>> * Qt5QmlModels (required version >= 5.15.7)
>> * Qt5Quick
>> * Qt5Test
>> * Qt5Svg
>> * Qt5QuickControls2
>> * Qt5Charts
>> * KF5Kirigami2 (required version >= 5.90.0)
>> * Gettext
>> * KF5I18n (required version >= 5.90.0)
>> * KF5Notifications (required version >= 5.90.0)
>> * KF5KWeatherCore (required version >= 0.6.0)
>> * KF5CoreAddons (required version >= 5.99.0)
>> * Qt5Gui (required version >= 5.15.2)
>> * Qt5Widgets (required version >= 5.15.2)
>> * KF5Plasma (required version >= 5.90.0)
>> * KF5 (required version >= 5.90.0)
>> * Qt5Qml
>> * Qt5Core
>> * Qt5
>>
>> -- The following features have been disabled:
>>
>> * SPDX_LICENSE_TESTING, Automatic license testing based on SPDX definitions (requires reuse tool)
>>
>> -- The following OPTIONAL packages have not been found:
>>
>> * ReuseTool
>>   Required to run tests of module ECMCheckOutboundLicense
>>
>> -- Configuring done
>> -- Generating done
>> -- Build files have been written to: /home/jeremy/data/devel/kde/src/kde/plasma-mobile/kweather/build
>>
>> then it built and installed fine, but trying to run failed with this:
>>
>> kweather
>> QQmlApplicationEngine failed to load component
>> qrc:/qml/main.qml:163:26: Type SettingsDialog unavailable
>> qrc:/qml/settings/SettingsDialog.qml:33:22: Type SettingsComponent unavailable
>> qrc:/qml/settings/SettingsComponent.qml:13:1: module "org.kde.kirigamiaddons.labs.mobileform" is not installed
>>
>> maybe cmake should have said it depends on kirigami?
>>
>> On Wed, Nov 9, 2022 at 3:00 PM Devin <espidev at gmail.com> wrote:
>>>
>>> Hi everyone,
>>>
>>> I would like to put kweather through kdereview:
>>>
>>> https://invent.kde.org/plasma-mobile/kweather
>>>
>>> KWeather is an application that can give simple weather information
>>> for different weather locations. Please note that KWeatherCore (the
>>> library the app depends on) has already passed kdereview.
>>>
>>> Thanks,
>>> Devin