RKWard is in kdereview - again

[Thomas Friedrichsmeier]

Hi,

On Mon, 28 Mar 2022 15:39:55 +0200
Nicolas Fella <nicolas.fella at gmx.de> wrote:
> I recently used RKWard for my Master Thesis, cool project!

thanks!

> A couple of observations:
> 
> - CommitPolicy.txt still mentions Phabricator, that should point to
> Gitlab instead

Done.

> - CommitPolicy.txt mentions Ubuntu Trusty as base for requirements,
> that is *ancient* by now, maybe 20.04 would be a more reasonable base?

Done.

> - The repo doesn't have Gitlab CI, that should be added

Yes. Help (or some pointers) on that would be appreciated, though.

> - Optional/nice-to-have: We tend to use SPDX indentifiers for license
> headers these days, maybe think about converting the existing headers

Deferred to the issue list, for now:
https://invent.kde.org/education/rkward/-/issues/8

> - You are using QtScript, which is deprecated. What's your plan for
> that?

I'm aware we'll have to to port to QJSEngine for KF6. I hope to start
looking into that, soon.

https://invent.kde.org/education/rkward/-/issues/6

> - I see you are distributing stable Windows releases, but there are no
> stable build jobs for that on binary-factory.kde.org

Yes, that's rather hackish. Last I asked, I was told to get out of
playground, before we could have separate stable builds (or was that
stable translations, one of these two, anyway). So kdereview is actually
part of the plan to get there.

> - Consider adding links to the Windows releases to the appstream
> metadata. That way they show up on apps.kde.org/rkward. See
> https://invent.kde.org/utilities/kate/-/merge_requests/667 for an
> example.

Thanks for the pointer. Done.

> - On Windows we tend to use the Breeze QStyle since that looks and
> works quite a bit better than the "native" style. See
> https://invent.kde.org/utilities/kate/-/blob/master/kate/main.cpp#L110
> 
> - Consider adding a color scheme selector (KColorSchemeManager) to the
> menu. On Windows that gives you dark mode support for free (this only
> really works nicely when using Breeze QStyle). See
> https://invent.kde.org/utilities/kate/-/blob/master/kate/katemainwindow.cpp#L235
> 
> - On Windows the title bar shows a generic icon instead of the RKWard
> icon

Will look into these, soon.

> - Consider publishing RKWard on the Microsoft Store
> 
> - Consider publshing RKWard on Flathub

Make sense. First step (for the latter) will be to create a flatpak, of
course.

> Feel free to reach out for questions/help with any of this.

Creating a flatpak is one of the things I shied away from looking into
too closely, so far. It does not look to complicated from a first
glance (yet I suppose we will have to include R, too), but I sure
wouldn't mind a volunteer stepping up...

Thanks for all the pointers!

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20220328/4d5f561e/attachment.sig>