Koko in KDEReview

[Carl Schwan]

Le dimanche, mars 14, 2021 12:22 AM, Albert Astals Cid <aacid at kde.org> a écrit :

> El dissabte, 13 de març de 2021, a les 20:14:26 CET, Carl Schwan va escriure:
>
> > Hi,
> > I would like to move Koko to KDEReview. Koko is a convergent image
> > viewer that works on both Plasma Desktop and Plasma Mobile. It's the
> > second try of Koko in KDEReview, the first try failed1 because Koko
> > didn't really worked with traditional packaging and was too focused
> > on the mobile usecase.
> > Since the first attempt, a lot of things changed. There is now
> > packaging instructions in the readme, and a lot of features have
> > been added:
> >
> > -   Simple image editor
> > -   Metadata editing and viewing (contributed by Mikel)
> > -   Slideshow (contributed by Mike)
> > -   Allow to open images from Dolphin with Koko
> > -   Better share dialog
> > -   Better file browsing (contributed by Mikel and me)
> > -   Remote folder browsing with KIO
> > -   Better indexing with live updates (contributed by Mikel)
> > -   Bookmark folders (contributed by Mikel)
> > -   Support of animated images (contributed by Mikel and me)
> > -   Make it possible to add pictures to favorites (contributed by Mikel)
> >
> > There are additionally two features that will hopefully be added soon:
> >
> > -   File operation (copy, move, delete, ...)
> > -   A better single image editor. Currently it is using simple QImage
> >     manipulation with a command pattern but to make it a bit more powerful
> >     and to support filters and other useful features this won't work. So
> >     I have been experimenting with glsl shaders and then rendering the
> >     image in an offscreen windows and another way and probably the safest one
> >     in term of maintenance and features of using the gegl library from GIMP.
> >     I would appreciate some opinions about that.
> >
> >
> > The repo: https://invent.kde.org/graphics/koko
> > The repo for the image editor: https://invent.kde.org/libraries/kquickimageeditor/
> > (required for koko to run)
>
> These two seem like should be fixable relatively easily
>
> QCommandLineParser: already having an option named "h"
> QCommandLineParser: already having an option named "help-all"
> QCommandLineParser: already having an option named "v"
>
> qrc:/qml/SelectionDelegateHighlight.qml:13: TypeError: Cannot read property 'z' of undefined

done
>
> While watching a photo in a folder, if i press Fullscreen i lose keyboard navigation with left/right arrows

Fixed https://invent.kde.org/graphics/koko/commit/dfa608bd127e3108993edb7728e2d1954ed59cab
>
> The "Select All" button does nothing? Or i don't understand what it does ^_^ Ahhhhhhh i see, it only selects images, not folders, that's a bit confusing. Maybe rename to Select All Images? Or it will be too long?

Using "Select All Images" is a good idea I think. At least when no image is selected and it's the only button in the toolbar. I will ask VDG for their opinion tomorrow.

> I would like to be able to move myself around in the "folder view" with the keyboard, but i understand that if this is mainly mobile oriented that's probably not so important.

Keyboard navigation has been something Mikel and I have been focused on, but the keyboard navigation in grid view has been more of a challenge I would have hoped. For some reasons the focus chain never go to the grid view :( I will try to investigate more.

> I would really like if we had a kxmlgui equivalent for QtQuick that gave me the "configure shortcuts" and stuff functionality, but that's unrelated to koko :)

Same (and also editable toolbars) :) I might give it a try somedays

> Cheers,
> Albert
>
> > Cheers,
> > Carl