New repo in kdereview: plasma-settings

Harald Sitter sitter at kde.org
Tue Feb 16 13:48:12 GMT 2021


On 15.02.21 07:16, Bhushan Shah wrote:
> Forwarding message, since had wrong reply to address in previous message
> 
> ----- Forwarded message from Bhushan Shah <bshah at mykolab.com> -----
> 
> Date: Mon, 15 Feb 2021 11:44:14 +0530
> From: Bhushan Shah <bshah at mykolab.com>
> To: Harald Sitter <sitter at kde.org>
> Subject: Re: New repo in kdereview: plasma-settings
> 
> On Mon, Jan 25, 2021 at 03:29:18PM +0100, Harald Sitter wrote:
>> Not sure if intentional but ModulesModel actually doesn't constrain to
>> settings KCMS. It'd also display info center kcms as well as (I think)
>> plugin KCMS (e.g. krunner's)
> 
> It is not intentional, but thinking about this I think it is fine, we
> are filtering them out based PLASMA_PLATFORM anyway.
> 
>> not installing a hicolor icon
> 
> We are reusing system settings icon from theme anyway, so not sure if I
> need to install something?

Fair points. +1

HS

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20210216/316264de/attachment.sig>


More information about the kde-core-devel mailing list