Move Koko to KDEReview
Adriaan de Groot
groot at kde.org
Mon Jun 15 10:05:03 BST 2020
On Friday, 12 June 2020 18:05:36 CEST Carl Schwan wrote:
> > I'm kind of unsure how i feel about it downloading things on cmake time.
> I asked a few packagers I know and for them, since the packagers can
> download the files and put them into the tarball, it should be fine. But
> they also said that it would be way better to have it fetched as run time
There's a couple of angles here:
- if your CMakeLists.txt tries to download something, it will fail.
- if you expect packagers to download additional files then put that in GIANT
LETTERS in several places; also make any attempted download fail gracefully
with a useful message ("additional source files are needed ..").
It's not that unusual for a single package to require multiple source tarballs
or additional source files, but you need to support it *and* be clear about
Koko does the right thing in accepting an already-downloaded file; it'd be
nice to fail more gracefully, and you should make it more prominent rather
than hidden on line 106 of CMakeLists.txt in a subdirectory.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel