Review Kid3

[Albert Astals Cid]

El dijous, 13 de febrer de 2020, a les 7:11:45 CET, Urs Fleisch va escriure:
> Hello everybody,
> 
> As you may know, Kid3, an audio tagger, has moved from SourceForge.net to
> kde.org. Jonathan Riddell is attending the incubation process as a sponsor.
> To complete the incubation, I would kindly ask you to execute a KDE review
> on the project.
> 
> Website: https://kid3.kde.org/
> Git, Issues: https://invent.kde.org/kde/kid3/
> Incubator: https://community.kde.org/Incubator/Projects/kid3
> Translation state: https://l10n.kde.org/stats/gui/trunk-kf5/po/kid3_qt.po/
> Documentation state: https://l10n.kde.org/stats/doc/trunk-kf5/po/kid3.po/
> 
> Kid3 exists since 2003 and I would say that it is quite mature. As it is
> also available as a Qt-only version (without KDE dependencies) and for
> macOS, Windows and Android, the build system differs a bit from the typical
> KDE application.

lupdate is complaining about singular messages

../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ singular' comment
../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ plural' comment
../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing '//~ singular' comment
../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing '//~ plural' comment
../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing '//~ singular' comment
../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing '//~ plural' comment

You should change the bug reporting to use bugzilla not your email address in KAboutData, the url of the webpage also seems "old"

$ kid3
QCommandLineParser: already having an option named "h"
QCommandLineParser: already having an option named "help-all"
QCommandLineParser: already having an option named "v"

Cheers,
  Albert


> 
> Best regards,
> Urs
>