KTrip in kdereview

[Albert Astals Cid]

El diumenge, 27 d’octubre de 2019, a les 15:29:10 CET, Nicolas Fella va escriure:
> Hi,
> 
> KTrip (https://invent.kde.org/kde/ktrip) has been moved to kdereview.
> 
> KTrip is a public transport assistant based on KPublicTransport targeted
> towards Plasma Mobile and Android. Currently it supports querying journeys
> between two locations as well as departures for a location but more advanced
> features are possible in the future.
> 
> Nightly builds for Android are available on the binary factory (https://
> binary-factory.kde.org/view/Android/job/KTrip_android/).
> 
> Destination would be extragear for now, but whatever comes out of KDE
> Applications might make sense.

You're not calling 
  KLocalizedString::setApplicationDomain
as far as i can see so translations won't work.


It would be good for it to use feature_summary so instead of a hard to read error http://paste.debian.net/1111810/ one would get the nice summary with "you're missing this required package, find it here"

Is running on the desktop supposed to work? http://paste.debian.net/1111811/

The time picker looks megaweird on the desktop https://i.imgur.com/ksBMhzj.png

What's the 3rd box here supposed to be? https://i.imgur.com/PQMvsgP.png Is it "wait there for a bit"?

Cheers,
  Albert

> 
> Cheers
> 
> Nico
> 
> 
>