Keysmith in kdereview

Friedrich W. H. Kossebau kossebau at
Sat Dec 28 17:38:41 GMT 2019

Sending my reply on-list while Johan's resent reply to list seems stuck in 

Am Samstag, 28. Dezember 2019, 15:03:33 CET schrieb Johan Ouwerkerk:
> On Wed, Dec 18, 2019 at 5:43 PM Friedrich W. H. Kossebau
> <kossebau at> wrote:
> > Other things noticed on superficial look:
> > * UI not translated, i18n support setup missing completely
> Yes, there is an issue for that on invent:

That one is a blocker though to pass kdereview, for what I understand from as linked from

At least personally I would expect this to be a minimum requirement for 
software created officially in the KDE community. Perhaps new generation of 
KDE develpoers thinks differently, but in that case please reconsider whether 
i18n is not a fundamental need :)

> > * uses own "ENABLE_TESTING", not "BUILD_TESTING" flag from
> > KDECompilerSettings> 
> >   proposed:
> >   + switch flag use to BUILD_TESTING
> >   - remove option(ENABLE_TESTING "Enable tests" ON)
> >   - remove enable_testing() (done by KDECompilerSettings)

My bad, s/KDECompilerSettings/KDECMakeSettings/g here.

> I'm not entirely sure what the origins of this are but see also the CI
> template for building flatpaks:
> yml As you can see from the example usage the `-DENABLE_TESTING` flag is
> suggested there.
> Speaking as a developer I don't really care what it is called, but I
> would like it to be on by default. Is that the case for

Main motivation here is consistency in the code created in the KDE community, 
so people working across KDE projects do not have to switch mind all the time.

Yes, BUILD_TESTING is ON by default, either indirectly via CTest or explicit, 
see$190 and

The people doing flatpaks want to fix the template, please poke them to do so 
(did already a comment on the commit myself, but someone needs to run after 
this to also happen :) ).


More information about the kde-core-devel mailing list