kdereview - xdg-desktop-portal-kde

Albert Astals Cid aacid at kde.org
Mon May 1 21:59:44 BST 2017

El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va escriure:
> Hi,
> I would like to request review of xdg-desktop-portal-kde [1]. We would like
> to make it part of Plasma releases, see [2].
> What is xdg-desktop-portal-kde:
> It's a KDE implementation of Flatpak portals backend [3], currently with
> support of AppChooser, FileChooser, Notification and Print portals.
> One mentioned issue on plasma-devel mailing list was usage of Qt's private
> print API. This will most likely go away if I find out it's useless,
> otherwise I'll have to keep it as it's used to set CUPS properties which
> are not available to the outside world.

Since you have copied some code from Okular maybe you can add some other (C) 
there other than RedHat's?

What about the unusued QVariantMap &results in the print.cpp file? What are 
you supposed to return there?

I've no idea how to use this so can't really test it :/


> [1] - https://cgit.kde.org/xdg-desktop-portal-kde.git/
> [2] - https://mail.kde.org/pipermail/plasma-devel/2017-April/069506.html
> [3] -
> http://flatpak.org/xdg-desktop-portal/portal-docs.html#idm140258860052032
> Regards,
> Jan

More information about the kde-core-devel mailing list