Zanshin is in kdereview

[Kevin Ottens]

Hello,

On Thursday, 8 June 2017 13:03:35 CEST Jonathan Riddell wrote:
> There's some GPL 2 only files in 3rdparty/kdepim, if they are used it
> means the applications can only be copied as GPL 2, consider
> contacting the copyright holders to fix this as it doesn't match the
> rest of the source.  (And fix it in kdepim if the same files are there
> with the same licence.)

Some of the people involved are listed in the relicense check script, I sent 
an email to the other ones in order to complete our database. Let's wait and 
see now...
 
> You have a release script in scripts/release.sh, consider using
> kde:releaseme as extracting translations can be quite faffy and
> releaseme does all that for you.

I tried that recently but didn't manage to get it to work at all. Failed with 
a backtrace leading to some obscure Ruby dependency and got stuck. Any 
guidance is welcome there, I'm especially interested because of the 
translation extraction bits which I do a bad job at since the beginning...

> There's no documentation.  I'm unsure how strong a requirement this is
> these days.

I honestly don't have the bandwidth to maintain such documentation at the 
moment.

> Is Todo a word? I think it should be but the dictionaries I checked
> haven't caught up with it. Maybe KDE can be at the forefront of
> English linguistic development here.

Addressed by: https://phabricator.kde.org/D6170

> Use title case on actions (menu items and buttons), "Next page" should
> be "Next Page" etc

Addressed by: https://phabricator.kde.org/D6171

> Single key shortcut for Move item is unusual, check with usability
> designer types if that's ok.

I'm very much attached to this. It's in fact mimicking what KMail does.

> If I stop Akonadi it silently stops working, an error message might be
> informative.

I'll see what can be done, I'll need to investigate on how best to address it. 
Is it a blocker for getting out of kdereview? If not please open a bug report 
about it.

> On my KDE neon User Edition install if I run Kontact it appears fine
> but on closing Kontact it crashes, this doesn't happen if I don't have
> Zanshin installed.

Do you have more information about that?

I got to admit I don't use this plugin and I'm regularly thinking about just 
dropping it, opinions welcome.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170610/cf710254/attachment.sig>