Zanshin is in kdereview

Sandro KnauƟ sknauss at kde.org
Mon Jul 3 15:40:53 BST 2017


Hey,

> > But I don't see why you are not just link against the relevant parts of
> > kdepim and remove the copy. And than tell kdepim that you are using these
> > files, so the team can take that into account when touching the files.
> 
> As I mentioned earlier I don't because that is private API meant only for
> consumption within kdepim applications. Depending on such API is wrong.

well I see zanshin also as a kdepim application. But as you said, that it was 
discussed before in person, so I don't want to open the discussion again.

> > Additionally you can add tests and cleanup the code yourself.
> That would be assuming I have the bandwidth for that: I don't.

That is bad :(

> > For me  the existence of those copies and no discussions with kdepim are a
> > -1 for moving it out of Review.
> 
> You're assuming this wasn't discussed previously. It's been discussed a long
> time ago in person. It's not like no one in kdepim knew about it.

Okay than I take back my -1, because there were discussions with kdepim.

Best Regards,

sandro
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170703/4a0df2e6/attachment.sig>


More information about the kde-core-devel mailing list