Review Request 129810: Add popup menu entry to invoke webshortcuts KCM

Heiko Becker heirecka at exherbo.org
Sun Jan 22 13:44:49 GMT 2017



> On Jan. 20, 2017, 12:02 vorm., David Faure wrote:
> > Isn't this KCM already available in "Configure Konqueror" ?
> > 
> > In any case this doesn't seem to me like the implementation of https://bugs.kde.org/show_bug.cgi?id=72646 which asks for a context menu for looking up the selection with a choice of webshortcuts (feature overkill? Dunno).

You're right, I misread the bug report. And the asked functionality is already there, so I guess it can be closed as resolved fixed.

I just stumbled about this because of a previously outdated name for the KCM and thought it would be nice to quickly get to the KCM when you realize the search engine you'd like to use is missing from the context menu, e.g. like it is done in okular.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129810/#review102109
-----------------------------------------------------------


On Jan. 19, 2017, 11:53 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129810/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 11:53 nachm.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Bugs: 72646
>     https;//bugs.kde.org/show_bug.cgi?id=72646
> 
> 
> Repository: konqueror
> 
> 
> Description
> -------
> 
> BUG: 72646
> 
> 
> Diffs
> -----
> 
>   webenginepart/src/webengineview.h 25b13eae9 
>   webenginepart/src/webengineview.cpp 1bed6110f 
> 
> Diff: https://git.reviewboard.kde.org/r/129810/diff/
> 
> 
> Testing
> -------
> 
> Builds, popup entry appears for selected text, clicking it opens the desired KCM.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170122/2691d6c4/attachment.htm>


More information about the kde-core-devel mailing list