Review Request 129810: Add popup menu entry to invoke webshortcuts KCM

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129810/#review102109
-----------------------------------------------------------



Isn't this KCM already available in "Configure Konqueror" ?

In any case this doesn't seem to me like the implementation of https://bugs.kde.org/show_bug.cgi?id=72646 which asks for a context menu for looking up the selection with a choice of webshortcuts (feature overkill? Dunno).

- David Faure


On Jan. 19, 2017, 10:53 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129810/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 10:53 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Bugs: 72646
>     https;//bugs.kde.org/show_bug.cgi?id=72646
> 
> 
> Repository: konqueror
> 
> 
> Description
> -------
> 
> BUG: 72646
> 
> 
> Diffs
> -----
> 
>   webenginepart/src/webengineview.h 25b13eae9 
>   webenginepart/src/webengineview.cpp 1bed6110f 
> 
> Diff: https://git.reviewboard.kde.org/r/129810/diff/
> 
> 
> Testing
> -------
> 
> Builds, popup entry appears for selected text, clicking it opens the desired KCM.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170119/9b597d16/attachment.htm>