Review Request 114448: kjs: reogranize basic math functions & function checking

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114448/#review102638
-----------------------------------------------------------



The patch was not commited 3 years ago. It still applies but given kdelibs is in heavy-important-bugfixes only mode i guess we should discard this? Will do in two weeks unless someone disagrees.

- Albert Astals Cid


On Dec. 14, 2013, 4:30 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114448/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 4:30 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kjs: reorganize basic math functions & function checking.
> Most noticeable change is that kjs will no longer quietly fail at runtime
> if a important function is missing, but fail at compiletime.
> This will only happen on a very strange platform, or a typo in my checks.
> Also note, I added more checks, so theoretically more platforms are now supported.
> 
> Ah yes and the math functions are now always inlined, not that it makes any huge performance difference...
> 
> 
> Diffs
> -----
> 
>   khtml/ecma/kjs_arraybuffer.cpp c4d2e51 
>   khtml/ecma/kjs_arraybufferview.h 4b6992b 
>   khtml/ecma/kjs_context2d.cpp bbdba8f 
>   kjs/CMakeLists.txt 48f5231 
>   kjs/config-kjs.h.cmake f644528 
>   kjs/date_object.cpp c8d776c 
>   kjs/function.cpp 1102208 
>   kjs/internal.cpp 49c2ce2 
>   kjs/jsonstringify.cpp e07a789 
>   kjs/math_object.cpp 89835e5 
>   kjs/number_object.cpp c284746 
>   kjs/operations.h 1112c2b 
>   kjs/operations.cpp 9e2fc71 
>   kjs/value.cpp f02aeea 
>   kjs/wtf/MathExtras.h 58be75b 
> 
> Diff: https://git.reviewboard.kde.org/r/114448/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170226/68370814/attachment.htm>