<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114448/">https://git.reviewboard.kde.org/r/114448/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch was not commited 3 years ago. It still applies but given kdelibs is in heavy-important-bugfixes only mode i guess we should discard this? Will do in two weeks unless someone disagrees.</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On December 14th, 2013, 4:30 p.m. UTC, Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2013, 4:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kjs: reorganize basic math functions & function checking.
Most noticeable change is that kjs will no longer quietly fail at runtime
if a important function is missing, but fail at compiletime.
This will only happen on a very strange platform, or a typo in my checks.
Also note, I added more checks, so theoretically more platforms are now supported.
Ah yes and the math functions are now always inlined, not that it makes any huge performance difference...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/ecma/kjs_arraybuffer.cpp <span style="color: grey">(c4d2e51)</span></li>
<li>khtml/ecma/kjs_arraybufferview.h <span style="color: grey">(4b6992b)</span></li>
<li>khtml/ecma/kjs_context2d.cpp <span style="color: grey">(bbdba8f)</span></li>
<li>kjs/CMakeLists.txt <span style="color: grey">(48f5231)</span></li>
<li>kjs/config-kjs.h.cmake <span style="color: grey">(f644528)</span></li>
<li>kjs/date_object.cpp <span style="color: grey">(c8d776c)</span></li>
<li>kjs/function.cpp <span style="color: grey">(1102208)</span></li>
<li>kjs/internal.cpp <span style="color: grey">(49c2ce2)</span></li>
<li>kjs/jsonstringify.cpp <span style="color: grey">(e07a789)</span></li>
<li>kjs/math_object.cpp <span style="color: grey">(89835e5)</span></li>
<li>kjs/number_object.cpp <span style="color: grey">(c284746)</span></li>
<li>kjs/operations.h <span style="color: grey">(1112c2b)</span></li>
<li>kjs/operations.cpp <span style="color: grey">(9e2fc71)</span></li>
<li>kjs/value.cpp <span style="color: grey">(f02aeea)</span></li>
<li>kjs/wtf/MathExtras.h <span style="color: grey">(58be75b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114448/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>