Review Request 129935: Fix build for GCC 7

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129935/#review102448
-----------------------------------------------------------


Ship it!




Ship It!

- Christoph Feck


On Feb. 8, 2017, 10:04 a.m., Antonio Larrosa Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129935/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 10:04 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This fixes building with GCC 7 which fails with
> "ISO C++ forbids comparison between pointer and integer [-fpermissive]"
> 
> 
> Diffs
> -----
> 
>   kdeui/windowmanagement/netwm.cpp 0c8b0a7d455f40327a03c685b7a7ff2beda901e0 
> 
> Diff: https://git.reviewboard.kde.org/r/129935/diff/
> 
> 
> Testing
> -------
> 
> I checked that building with GCC 7 shows:
> /usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member function 'void NETWinInfo::update(const long unsigned int*)':
> /usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
>              p->blockCompositing = (data_ret != None);
>                                                 ^~~~
>                                                 
> and the submitted commit fixes this.
> 
> 
> Thanks,
> 
> Antonio Larrosa Jimenez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170208/779aec8e/attachment.htm>