Review Request 129935: Fix build for GCC 7

Antonio Larrosa Jimenez larrosa at kde.org
Wed Feb 8 09:04:00 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129935/
-----------------------------------------------------------

Review request for kdelibs.


Repository: kdelibs


Description
-------

This fixes building with GCC 7 which fails with
"ISO C++ forbids comparison between pointer and integer [-fpermissive]"


Diffs
-----

  kdeui/windowmanagement/netwm.cpp 0c8b0a7d455f40327a03c685b7a7ff2beda901e0 

Diff: https://git.reviewboard.kde.org/r/129935/diff/


Testing
-------

I checked that building with GCC 7 shows:
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member function 'void NETWinInfo::update(const long unsigned int*)':
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
             p->blockCompositing = (data_ret != None);
                                                ^~~~
                                                
and the submitted commit fixes this.


Thanks,

Antonio Larrosa Jimenez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20170208/5d927d19/attachment.htm>


More information about the kde-core-devel mailing list