kdelibs-4.14.35 bug report

[Albert Astals Cid]

El divendres, 18 d’agost de 2017, a les 7:25:44 CEST, David Binderman va 
escriure:
> Hello there,
> 
> Some suspicious code:
> 
> [kdelibs-4.14.35/kde3support/kdeui/k3listview.cpp:505]: (style) Same
> expression on both sides of '||'.
> 
> Source code is
> 
>     if ( ca == Qt::AlignLeft || ca == Qt::AlignLeft ) {
> 
> Maybe better code
> 
>     if ( ca == Qt::AlignLeft || ca == Qt::AlignRight ) {

Most probably

But at this point i'd rather not change the kde3support code, it's veeeery old 
and mostly frozen, anyone that was affected by this bug probably workarounded 
it already so i'd rather not touch it since it may as well break the 
workaround they had.

Thanks for the report :)

Cheers,
  Albert

> 
> Regards
> 
> David Binderman