Review Request 128909: initial, minimal support for OS X

René J.V. Bertin rjvbertin at gmail.com
Thu Sep 22 20:25:30 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128909/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 9:25 p.m.)


Review request for KDE Base Apps and KDE Software on Mac OS X.


Changes
-------

Hope I didn't introduce any more "wrong indentation" issues resolving the ones in ReniceDlg.cpp, or introduced "separate ticket" issues because the file isn't exactly consistent in its indentation...


Repository: libksysguard


Description
-------

This patch implements initial and rather minimal support for OS X, for now focussing purely on process information. That feature is justified as it is used by KDevelop in order to obtain the list of processes one can attach a debugger to.

Mac OS X is tricky because it requires special privileges in order to obtain certain types of information for any running process. For example, even obtaining the number of threads spawned by a foreign process requires privileges that aren't trivial to set up. I've prepared the terrain, but also implemented a fallback strategy that calls `ps` to be sure that crucial information like the command name is available for all processes.


Diffs (updated)
-----

  processcore/CMakeLists.txt e7c9263 
  processcore/Info.plist PRE-CREATION 
  processcore/processes_darwin_p.cpp PRE-CREATION 
  processcore/processes_local_p.cpp 2bc123f 
  processui/ReniceDlg.cpp a97563f 
  processui/ksysguardprocesslist.cpp 44603de 

Diff: https://git.reviewboard.kde.org/r/128909/diff/


Testing
-------

On OS X 10.9.5 with Frameworks 5.24.0 and Qt 5.6.1


File Attachments
----------------

Attach to Process widget in KDevelop
  https://git.reviewboard.kde.org/media/uploaded/files/2016/09/14/47468811-58cb-40b8-a735-4dd86dce98e1__Screen_Shot_2016-09-14_at_17.38.22.png


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160922/a735dcaa/attachment.htm>


More information about the kde-core-devel mailing list