Review Request 128910: [kio_trash] Fill in UDS_LOCAL_PATH in UDSEntry

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128910/
-----------------------------------------------------------

Review request for KDE Runtime, KDE Frameworks and David Faure.


Bugs: 208625, 272249, 329155, and 368104
    https://bugs.kde.org/show_bug.cgi?id=208625
    https://bugs.kde.org/show_bug.cgi?id=272249
    https://bugs.kde.org/show_bug.cgi?id=329155
    https://bugs.kde.org/show_bug.cgi?id=368104


Repository: kio


Description
-------

Not doing so results in PreviewJob assuming the files/folders are remote and copying them to /tmp when generating previews.
This is especially annoying and dangerous if there are large folders in the trash.

KDE4's kio_trash in kde-runtime has the same problem, as the code is basically the same, the same patch fixes it too.


Diffs
-----

  src/ioslaves/trash/kio_trash.cpp 3810941 

Diff: https://git.reviewboard.kde.org/r/128910/diff/


Testing
-------

Trash some files/folders, open dolphin, navigate to trash:/, and hover over them.
Previews are still generated (if enabled), and the files/folders are not copied to /tmp any more.

Also tried with files on an USB stick, where a folder .Trash-XXX is used as trash.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160914/0191f0d9/attachment.htm>