Review Request 128910: [kio_trash] Fill in UDS_LOCAL_PATH in UDSEntry

Wolfgang Bauer wbauer at
Wed Sep 14 19:02:57 BST 2016

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Runtime, KDE Frameworks and David Faure.

Bugs: 208625, 272249, 329155, and 368104

Repository: kio


Not doing so results in PreviewJob assuming the files/folders are remote and copying them to /tmp when generating previews.
This is especially annoying and dangerous if there are large folders in the trash.

KDE4's kio_trash in kde-runtime has the same problem, as the code is basically the same, the same patch fixes it too.


  src/ioslaves/trash/kio_trash.cpp 3810941 



Trash some files/folders, open dolphin, navigate to trash:/, and hover over them.
Previews are still generated (if enabled), and the files/folders are not copied to /tmp any more.

Also tried with files on an USB stick, where a folder .Trash-XXX is used as trash.


Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list