announcement: Kwave is in kdereview

[Albert Astals Cid]

El dissabte, 8 d’octubre de 2016, a les 9:39:24 CEST, Thomas Eschenbacher va escriure:
> Hello,
> 
> according to
> https://community.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable
> I hereby announce the move of Kwave to "kdereview", on it's way to
> "kdemultimedia".

These warnings look like nice to fix
kf5.kcoreaddons.kaboutdata: Could not initialize the equivalent properties of Q*Application: no instance (yet) existing.
kf5.kcoreaddons.kaboutdata: QCoreApplication::organizationDomain "kde.org" is out-of-sync with KAboutData::applicationData().organizationDomain "sourceforge.net"
kf5.kcoreaddons.kaboutdata: QGuiApplication::applicationDisplayName "kwave" is out-of-sync with KAboutData::applicationData().displayName "Kwave"
kf5.kcoreaddons.kaboutdata: QGuiApplication::desktopFileName "" is out-of-sync with KAboutData::applicationData().desktopFileName "net.sourceforge.kwave"
kf5.kcoreaddons.kaboutdata: QCoreApplication::organizationDomain "kde.org" is out-of-sync with KAboutData::applicationData().organizationDomain "sourceforge.net"
kf5.kcoreaddons.kaboutdata: QGuiApplication::applicationDisplayName "kwave" is out-of-sync with KAboutData::applicationData().displayName "Kwave"
kf5.kcoreaddons.kaboutdata: QGuiApplication::desktopFileName "" is out-of-sync with KAboutData::applicationData().desktopFileName "net.sourceforge.kwave"


About -> kwave gives me a bunch of
Trying to convert empty KLocalizedString to QString.
Trying to convert empty KLocalizedString to QString.
Trying to convert empty KLocalizedString to QString.
Trying to convert empty KLocalizedString to QString.
Trying to convert empty KLocalizedString to QString.
Trying to convert empty KLocalizedString to QString.
Trying to convert empty KLocalizedString to QString.



Pressed File->record and i got
   http://i.imgur.com/DUhCvVA.png
I guess that's probably because that user doesn't have enough permissions to use some of the sound stuff that is neede, but a nicer error dialog would be really appreciated.



You don't seem to be using some of the nice stuff that KF5 provides, I miss the "Configure Shortcuts" dialog :/


valgrind did report some memory leaks in Kwave::MenuSub::insertLeaf and then there's a few in libasound that you may want to check if it is that you're forgetting to free/close some asound structures/something.

Cheers,
  Albert