Review Request 129518: Konqueror: restore "Default web browser engine" setting

[Jonathan Marten]

> On Nov. 21, 2016, 12:44 p.m., David Faure wrote:
> > settings/konqhtml/generalopts.cpp, line 277
> > <https://git.reviewboard.kde.org/r/129518/diff/1/?file=486354#file486354line277>
> >
> >     That is actually not fully correct anymore, any process making a trader query should get updated information automatically, the sycoca rebuilding happening in-process if necessary. Can you try removing it?

Have tried removing the KBuildSycocaProgressDialog::rebuildKSycoca(this) and it doesn't seem to work.  What happens (under a full Plasma 5 desktop) is:

  Start with engine set to WebKit
  kcmshell5 khtml_general, change web engine to KHTML then OK
    => mimeapps.list is updated with khtml.desktop at the front of the list, but there is no kbuildsycoca activity
  konqueror www.kde.org
    => still opens in WebKit
  keditfiletype5 text/html
    => "Embedding" tab still has WebKit at the top of the list
  kbuildsycoca5
  konqueror www.kde.org
    => now opens in KHTML
  keditfiletype5 text/html
    => "Embedding" tab now has KHTML at the top of the list


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129518/#review101013
-----------------------------------------------------------


On Nov. 21, 2016, 12:25 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129518/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 12:25 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: konqueror
> 
> 
> Description
> -------
> 
> This settings was originally commented out in the sources, requiring a port to Qt5.  There was not actually much porting to be done, apart from setting the correct QStandardPaths location for the mimeapps.list file, but I've also tidied up and removed a lot of the old cruft and unused code.
> 
> 
> Diffs
> -----
> 
>   settings/konqhtml/generalopts.cpp facec057 
> 
> Diff: https://git.reviewboard.kde.org/r/129518/diff/
> 
> 
> Testing
> -------
> 
> Built Konqueror with these changes, checked correct operation of the Settings - Configure Konqueror - General dialogue and the setting of the preferred association for the HTML MIME types.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161121/9e5a667a/attachment.htm>