Review Request 129518: Konqueror: restore "Default web browser engine" setting

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129518/#review101013
-----------------------------------------------------------


Fix it, then Ship it!




Thanks!


settings/konqhtml/generalopts.cpp (line 258)
<https://git.reviewboard.kde.org/r/129518/#comment67736>

    That is actually not fully correct anymore, any process making a trader query should get updated information automatically, the sycoca rebuilding happening in-process if necessary. Can you try removing it?


- David Faure


On Nov. 21, 2016, 12:25 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129518/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 12:25 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: konqueror
> 
> 
> Description
> -------
> 
> This settings was originally commented out in the sources, requiring a port to Qt5.  There was not actually much porting to be done, apart from setting the correct QStandardPaths location for the mimeapps.list file, but I've also tidied up and removed a lot of the old cruft and unused code.
> 
> 
> Diffs
> -----
> 
>   settings/konqhtml/generalopts.cpp facec057 
> 
> Diff: https://git.reviewboard.kde.org/r/129518/diff/
> 
> 
> Testing
> -------
> 
> Built Konqueror with these changes, checked correct operation of the Settings - Configure Konqueror - General dialogue and the setting of the preferred association for the HTML MIME types.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161121/69d3158f/attachment.htm>