Review Request 129340: Make building drkonqi optional

Antonio Rojas arojas at archlinux.org
Thu Nov 10 16:01:02 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129340/
-----------------------------------------------------------

(Updated Nov. 10, 2016, 6:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Runtime and Rex Dieter.


Changes
-------

Submitted with commit a87fd4a4e4b768359bc71485f23f9f27a103de53 by Antonio Rojas to branch master.


Repository: kde-runtime


Description
-------

The KF5 version of drkonqi works fine with KDE4 applications, as long as it is installed where KStandardDirs can find it. Make building the KDE4 version optional. Together with RR129339, this will allow distros to drop the kdepimlibs dependency from kde-runtime


Diffs
-----

  CMakeLists.txt 8b4d0f2 

Diff: https://git.reviewboard.kde.org/r/129340/diff/


Testing
-------

Builds fine. KDE4 applications open the KF5 version of drkonqi when crashing, if it is installed in /usr/bin (or symlinked in /usr/lib/kde4/libexec)


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161110/f0314af7/attachment.htm>


More information about the kde-core-devel mailing list