Review Request 129340: Make building drkonqi optional

[Heiko Becker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129340/#review100759
-----------------------------------------------------------



+1

Thanks for bringing this up. Had the same patch lying around locally.

- Heiko Becker


On Nov. 5, 2016, 11:07 vorm., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129340/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 11:07 vorm.)
> 
> 
> Review request for KDE Runtime and Rex Dieter.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> The KF5 version of drkonqi works fine with KDE4 applications, as long as it is installed where KStandardDirs can find it. Make building the KDE4 version optional. Together with RR129339, this will allow distros to drop the kdepimlibs dependency from kde-runtime
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8b4d0f2 
> 
> Diff: https://git.reviewboard.kde.org/r/129340/diff/
> 
> 
> Testing
> -------
> 
> Builds fine. KDE4 applications open the KF5 version of drkonqi when crashing, if it is installed in /usr/bin (or symlinked in /usr/lib/kde4/libexec)
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161110/26b15149/attachment.htm>