Review Request 129339: Allow building kwalletd against gpgme++ from gpgme 1.7

Antonio Rojas arojas at archlinux.org
Thu Nov 10 15:58:50 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129339/
-----------------------------------------------------------

(Updated Nov. 10, 2016, 3:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Runtime and Andreas Sturmlechner.


Changes
-------

Submitted with commit 1b80d1d0b961f8e28186928ede2b87af292c3de4 by Antonio Rojas to branch master.


Repository: kde-runtime


Description
-------

This patch, based on the one from the kwallet repo, allows building kwalletd against the gpgme++ library provided by gpgme 1.7 instead of the kdepimlibs one.


Diffs
-----

  kwalletd/CMakeLists.txt 73aec82 
  kwalletd/backend/CMakeLists.txt 4db348f 
  kwalletd/backend/backendpersisthandler.cpp b7f63f8 
  kwalletd/kwalletwizard.cpp 78de78d 

Diff: https://git.reviewboard.kde.org/r/129339/diff/


Testing
-------

Built:
1) with kdepimlibs
2) with no kdepimlibs and gpgme 1.7
3) with no kdepimlibs and no gpgme

Builds correctly in all cases, links to the expected version of libgpgme++ in the first two cases. In the first case there is no change in behaviour with respect to the previous situation.


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161110/a26e36fc/attachment.htm>


More information about the kde-core-devel mailing list