Review Request 129339: Allow building kwalletd against gpgme++ from gpgme 1.7

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129339/#review100701
-----------------------------------------------------------



Looks good to me, as far as i understand it prefers "the old way" and if it can not find the old way it uses the new headers, makes sense. I am not an expert on the code but if it's based on something that was commited in kwallet.git already I don't see why you could not commit unless there's real objections by someone.

- Albert Astals Cid


On Nov. 5, 2016, 9:35 a.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129339/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 9:35 a.m.)
> 
> 
> Review request for KDE Runtime and Andreas Sturmlechner.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This patch, based on the one from the kwallet repo, allows building kwalletd against the gpgme++ library provided by gpgme 1.7 instead of the kdepimlibs one.
> 
> 
> Diffs
> -----
> 
>   kwalletd/CMakeLists.txt 73aec82 
>   kwalletd/backend/CMakeLists.txt 4db348f 
>   kwalletd/backend/backendpersisthandler.cpp b7f63f8 
>   kwalletd/kwalletwizard.cpp 78de78d 
> 
> Diff: https://git.reviewboard.kde.org/r/129339/diff/
> 
> 
> Testing
> -------
> 
> Built:
> 1) with kdepimlibs
> 2) with no kdepimlibs and gpgme 1.7
> 3) with no kdepimlibs and no gpgme
> 
> Builds correctly in all cases, links to the expected version of libgpgme++ in the first two cases. In the first case there is no change in behaviour with respect to the previous situation.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20161107/db6c99fd/attachment.htm>