Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

Thomas Pfeiffer thomas.pfeiffer at kde.org
Wed May 4 10:04:59 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127815/#review95153
-----------------------------------------------------------



Makes sense!

- Thomas Pfeiffer


On May 2, 2016, 7:04 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127815/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 7:04 p.m.)
> 
> 
> Review request for KDE Base Apps and KDE Usability.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> While searching the entire tab widget got disabled so you couldn't even switch tabs to see what you're actually looking for, eg. if you started searching while on the "Properties" tab you couldn't switch to the "Name/Location" tab.
> 
> This patch disables only the tab contents while still allowing to switch tabs.
> 
> 
> Diffs
> -----
> 
>   kfind/kftabdlg.cpp 3de1bfe 
> 
> Diff: https://git.reviewboard.kde.org/r/127815/diff/
> 
> 
> Testing
> -------
> 
> Works. I was surprised to find kde-baseapps master still being 4.x-based.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/7dfbde66-ded8-4881-b7d4-86ba253afae4__kfindbefore.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/d7d22fb6-c326-41c3-836a-4fa3bce8cc76__kfindafter.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160504/18f61af7/attachment.htm>


More information about the kde-core-devel mailing list