[KDE Usability] Review Request 127815: [KFind] Disable only tab contents not the entire tab bar

Kai Uwe Broulik kde at privat.broulik.de
Mon May 2 20:04:31 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127815/
-----------------------------------------------------------

(Updated Mai 2, 2016, 7:04 nachm.)


Review request for KDE Base Apps and KDE Usability.


Changes
-------

Enable tabs again afterwards :)


Repository: kde-baseapps


Description
-------

While searching the entire tab widget got disabled so you couldn't even switch tabs to see what you're actually looking for, eg. if you started searching while on the "Properties" tab you couldn't switch to the "Name/Location" tab.

This patch disables only the tab contents while still allowing to switch tabs.


Diffs (updated)
-----

  kfind/kftabdlg.cpp 3de1bfe 

Diff: https://git.reviewboard.kde.org/r/127815/diff/


Testing
-------

Works. I was surprised to find kde-baseapps master still being 4.x-based.


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/7dfbde66-ded8-4881-b7d4-86ba253afae4__kfindbefore.png
After
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/02/d7d22fb6-c326-41c3-836a-4fa3bce8cc76__kfindafter.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160502/8961927a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


More information about the kde-core-devel mailing list