Review Request 127515: Port away keditbookmarks from KCmdLine* and K4AboutData

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127515/
-----------------------------------------------------------

(Updated March 29, 2016, 1:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Base Apps and David Faure.


Changes
-------

Submitted with commit f7266d77bd11c678689bc64bdc5697f7ad1c76fd by Luigi Toscano to branch frameworks.


Repository: kde-baseapps


Description
-------

Starting point: the output of convert-kcmdlineargs.pl
    
Then cleanups: moved statements as suggested by scripts comments; converted the remaining items (ki18n, etc); fixed headers; added consts, QStringLiteral, translation domain; fixed termination on parser validity errors (away from KCmdLineArgs::usage); etc, etc.
    
Set keditbookmarks version to 5.0.
    
Explicitly added KI18n and CoreAddons to the required libraries (cmake).
    
Commented out app.disableSessionManagement in kbookmarkmerger for now (probably not critical anyway).

-----------------
If this proves to be correct, can I push directly push further porting commits/cleanups to keditbookmarks (hoping for a standalone KF5 release in the not far future) or do you prefer to review all changes?


Diffs
-----

  keditbookmarks/CMakeLists.txt b44f389 
  keditbookmarks/kbookmarkmerger.cpp 5f17a98 
  keditbookmarks/main.cpp 4302318 

Diff: https://git.reviewboard.kde.org/r/127515/diff/


Testing
-------

Compile, the two programs can run, now with proper version details. No apparent regression in parameter parsing.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160329/f5294d45/attachment.htm>