Review Request 127515: Port away keditbookmarks from KCmdLine* and K4AboutData

Luigi Toscano luigi.toscano at
Tue Mar 29 21:40:03 BST 2016

This is an automatically generated e-mail. To reply, visit:

(Updated March 29, 2016, 10:40 p.m.)

Review request for KDE Base Apps and David Faure.


Update with the requested fixes for reference.

Repository: kde-baseapps


Starting point: the output of
Then cleanups: moved statements as suggested by scripts comments; converted the remaining items (ki18n, etc); fixed headers; added consts, QStringLiteral, translation domain; fixed termination on parser validity errors (away from KCmdLineArgs::usage); etc, etc.
Set keditbookmarks version to 5.0.
Explicitly added KI18n and CoreAddons to the required libraries (cmake).
Commented out app.disableSessionManagement in kbookmarkmerger for now (probably not critical anyway).

If this proves to be correct, can I push directly push further porting commits/cleanups to keditbookmarks (hoping for a standalone KF5 release in the not far future) or do you prefer to review all changes?

Diffs (updated)

  keditbookmarks/CMakeLists.txt b44f389 
  keditbookmarks/kbookmarkmerger.cpp 5f17a98 
  keditbookmarks/main.cpp 4302318 



Compile, the two programs can run, now with proper version details. No apparent regression in parameter parsing.


Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list