Review Request 127393: digital-clock: Fix font size of date label in small panels

[Daniel Faust]

> On März 16, 2016, 9:31 nachm., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 382-383
> > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line382>
> >
> >     You can't set both, it will print an error that you can't and one is ignored
> >     
> >     Also leave this in the font { } format please
> 
> Daniel Faust wrote:
>     Yes, I copy'n'pasted it. How about I throw in an additional commit to fix it everywhere in the file?
> 
> Martin Klapetek wrote:
>     Well changing code just for the sake of change is not
>     really worth it as it makes looking up history of that
>     line, the actual change, needlessly harder.

Yeah, you're right.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127393/#review93620
-----------------------------------------------------------


On März 19, 2016, 2:16 nachm., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127393/
> -----------------------------------------------------------
> 
> (Updated März 19, 2016, 2:16 nachm.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 360059
>     https://bugs.kde.org/show_bug.cgi?id=360059
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently the digital clock applet uses a fixed font size for the date label when it's placed in a narrow horizontal panel.
> Example: http://paste.opensuse.org/view/raw/f8ba5d0d
> 
> With this patch the same font size is used as for the time label.
> 
> As mentioned at https://git.reviewboard.kde.org/r/127102/ I'm not sure if the current design is a bug or intentional.
> On the one hand having a smaller font size reduces the width of the applet, on the other hand having the same font size is more consistent.
> I would prefer a consistent look however.
> 
> This patch creates one problem though. Currently the height of the date-time-separator is set to the height of the (fixed) date label font size.
> With this patch I set the separator height to 70% of the applet height.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 02d55a9 
> 
> Diff: https://git.reviewboard.kde.org/r/127393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160319/0cd2f915/attachment.htm>