Review Request 127393: digital-clock: Fix font size of date label in small panels

[Martin Klapetek]

> On March 16, 2016, 9:31 p.m., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 382-383
> > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line382>
> >
> >     You can't set both, it will print an error that you can't and one is ignored
> >     
> >     Also leave this in the font { } format please
> 
> Daniel Faust wrote:
>     Yes, I copy'n'pasted it. How about I throw in an additional commit to fix it everywhere in the file?

Well changing code just for the sake of change is not
really worth it as it makes looking up history of that
line, the actual change, needlessly harder.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127393/#review93620
-----------------------------------------------------------


On March 16, 2016, 4:53 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127393/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 4:53 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently the digital clock applet uses a fixed font size for the date label when it's placed in a narrow horizontal panel.
> Example: http://paste.opensuse.org/view/raw/f8ba5d0d
> 
> With this patch the same font size is used as for the time label.
> 
> As mentioned at https://git.reviewboard.kde.org/r/127102/ I'm not sure if the current design is a bug or intentional.
> On the one hand having a smaller font size reduces the width of the applet, on the other hand having the same font size is more consistent.
> I would prefer a consistent look however.
> 
> This patch creates one problem though. Currently the height of the date-time-separator is set to the height of the (fixed) date label font size.
> With this patch I set the separator height to 70% of the applet height.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160317/71f52d15/attachment.htm>