Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

David Faure faure at kde.org
Thu Mar 10 22:19:33 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93401
-----------------------------------------------------------



I don't really see how it's the same idea as a commit where I set CMP0054 (not 64) to NEW (not OLD).

Setting a policy to OLD means "I know I'm using something deprecated and I don't care", which isn't exactly a good solution in the long term.

Can you try actually doing the same as that other commit, i.e. setting CMP0054 to NEW instead?

- David Faure


On March 3, 2016, 12:58 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 12:58 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
> 
> 
> Diffs
> -----
> 
>   cmake/modules/KDE4Macros.cmake 5bb2ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160310/3fb7713a/attachment.htm>


More information about the kde-core-devel mailing list