Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125297/#review85590
-----------------------------------------------------------


a) fix the test?
b) the patch first limits to a Url subset and then guesses what it was ... if that is the "fix" it smell like okular or the test scenario cannot deal with remote files?


shell/okular_main.cpp (line 169)
<https://git.reviewboard.kde.org/r/125297/#comment59144>

    toString(QUrl::FullyEncoded)



shell/shell.cpp (line 179)
<https://git.reviewboard.kde.org/r/125297/#comment59145>

    QUrl(url, QUrl::StrictMode)


- Thomas Lübking


On Sept. 17, 2015, 9:06 nachm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125297/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 9:06 nachm.)
> 
> 
> Review request for kdelibs and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> When running the mainshelltest the tests that fail report being unable to call openDocument because of it's QUrl parameter. With this it no longer complains about that (but the tests still fail).
> 
> 
> Diffs
> -----
> 
>   shell/okular_main.cpp 1c988d9 
>   shell/shell.h c16a0b2 
>   shell/shell.cpp d0204f9 
> 
> Diff: https://git.reviewboard.kde.org/r/125297/diff/
> 
> 
> Testing
> -------
> 
> Test no longer complains about being unable to call openDocument.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150917/a5cad6d4/attachment.htm>