Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125297/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 3:06 p.m.)


Review request for kdelibs and Albert Astals Cid.


Changes
-------

Remove unused KTabWidget slots instead of commenting out the connect only.


Repository: okular


Description
-------

When running the mainshelltest the tests that fail report being unable to call openDocument because of it's QUrl parameter. With this it no longer complains about that (but the tests still fail).


Diffs (updated)
-----

  shell/okular_main.cpp 1c988d9 
  shell/shell.h c16a0b2 
  shell/shell.cpp d0204f9 

Diff: https://git.reviewboard.kde.org/r/125297/diff/


Testing
-------

Test no longer complains about being unable to call openDocument.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150917/778c899c/attachment.htm>