SIC/BIC in Frameworks (NOT)

[Ben Cooksley]

On Tue, Sep 15, 2015 at 12:42 AM, Scarlett Clark
<scarlett.gately.clark at gmail.com> wrote:
> I guess I  forgot to turn back on clean workspace? We were debugging qt5.5.
> I
> Am so sorry, been traveling home.

No worries, it's all fixed now :)

> Scarlett

Cheers,
Ben

>
> On Sep 14, 2015 12:59 PM, "Ben Cooksley" <bcooksley at kde.org> wrote:
>>
>> On Mon, Sep 14, 2015 at 12:28 AM, David Faure <faure at kde.org> wrote:
>> > This is clearly a CI issue, not a SIC/BIC, as both our investigations
>> > prove.
>>
>> And now fixed.
>>
>> >
>> > On Sunday 13 September 2015 23:43:19 Ben Cooksley wrote:
>> >> This then causes KNotification to fail to build (as it depends on
>> >> netwm.h) which then leads to the rest of the failures we see. This
>> >> itself is probably a bug?
>> >
>> > If KWindowSystem is built with X11 forced OFF
>> > (via CMAKE_DISABLE_FIND_PACKAGE_X11)
>> > and KNotifications is built with X11 enabled
>> > (CMAKE_DISABLE_FIND_PACKAGE_X11 not being set),
>> > you end up with a compilation error.
>> > I think that's quite obvious, and I wouldn't consider that a bug.
>> >
>> > We only support X11 on everywhere or off everywhere.
>> > Combinations of "some frameworks with X11 enabled and some with
>> > X11 purposefully disabled" don't make sense to me.
>>
>> Indeed, but couldn't they raise an error if one is built without X11
>> support but the others are trying to build with X11 support?
>>
>> >
>> > --
>> > David Faure, faure at kde.org, http://www.davidfaure.fr
>> > Working on KDE Frameworks 5
>> >
>>
>> Cheers,
>> Ben
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel