Review Request 125081: Fix build on OS X

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125081/#review84983
-----------------------------------------------------------


Ideally the usage of netwm should be removed. NETWM is very low-level - valid users are KWin and Plasma and KWindowsystem itself and that's it. So I am relatively sure that the usage of NETWM in Konqueror is just wrong and can be replaced by an abstracting API in KWindowsystem.

- Martin Gräßlin


On Sept. 8, 2015, 12:08 a.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125081/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 12:08 a.m.)
> 
> 
> Review request for KDE Base Apps and Martin Gräßlin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Use kwindowsystem.h to check whether X11 is available and move netwm.h with them since that header is made available with the xcb plugin.
> 
> 
> added .reviewboardrc
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   konqueror/src/konqmainwindow.cpp c7a81c8 
> 
> Diff: https://git.reviewboard.kde.org/r/125081/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150908/fc3a6a8e/attachment.htm>