Review Request 125081: Fix build on OS X
Martin Gräßlin
mgraesslin at kde.org
Tue Sep 8 06:43:51 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125081/#review84982
-----------------------------------------------------------
konqueror/src/konqmainwindow.cpp (line 150)
<https://git.reviewboard.kde.org/r/125081/#comment58789>
Please don't use the KWINDOWSYSTEM_HAVE_X11 but instead find XCB yourself and define your own HAVE_X11.
KWIND)WSYSTEM_HAVE_X11 is not public API.
- Martin Gräßlin
On Sept. 8, 2015, 12:08 a.m., Samuel Gaist wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125081/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 12:08 a.m.)
>
>
> Review request for KDE Base Apps and Martin Gräßlin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Use kwindowsystem.h to check whether X11 is available and move netwm.h with them since that header is made available with the xcb plugin.
>
>
> added .reviewboardrc
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> konqueror/src/konqmainwindow.cpp c7a81c8
>
> Diff: https://git.reviewboard.kde.org/r/125081/diff/
>
>
> Testing
> -------
>
> Build on OS X 10.8
>
>
> Thanks,
>
> Samuel Gaist
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150908/e59a456c/attachment.htm>
More information about the kde-core-devel
mailing list