Review Request 123806: [klipper] Ignore empty / blank entries

Thomas L├╝bking thomas.luebking at gmail.com
Thu May 21 23:36:31 BST 2015



> On Mai 21, 2015, 5:02 nachm., Patrick Eigensatz wrote:
> > klipper/klipper.kcfg, line 24
> > <https://git.reviewboard.kde.org/r/123806/diff/7/?file=370396#file370396line24>
> >
> >     **Question:** Compiled plasma-workspace using *kdesrc-build --include-dependencies plasma-workspace*, applied patch and compiled again.
> >     -> Build broken because g++ could not
> >     locate *klippersettings.h* included in *historyitem.cpp*. Shouldn't this file be generated by *cmake*?
> >     If I generate *klippersettings{.h,.cpp}* using *kconfig_compiler klipper.kcfg klippersettings.kcfgc* and run *kdesrc* again,
> >     I get a build error:
> >     
> >         CMakeFiles/testHistory.dir/__/historyitem.cpp.o: In function `KlipperSettings::allowWhitespaceEntries()':
> >         /home/patrick/kdesrc/plasma-workspace/klipper/klippersettings.h:72: undefined reference to `KlipperSettings::self()'
> >     
> >     
> >     Note: The whole file is full of *return self()->member*, I don't know why it fails on line 72 if it worked
> >     the for last 20 members. (I didn't change anything, original kconfig_compiler output)

> Shouldn't this file be generated by cmake?

Yes, in the build dir.

> I get a build error:

That's a linker error. No idea about the actual reason (w/o seeing the source), but kconfig_compiler_kf5 should be used to generate that file.
I assume you don't have that tool and that's why the config build failed in the first place?

Arch ships it with the kconfig package, your distro might have it in some kconfig-dev?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80705
-----------------------------------------------------------


On Mai 21, 2015, 5 nachm., Patrick Eigensatz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123806/
> -----------------------------------------------------------
> 
> (Updated Mai 21, 2015, 5 nachm.)
> 
> 
> Review request for kde-workspace, KDE Usability and Patrick Eigensatz.
> 
> 
> Bugs: 159267 and 192922
>     https://bugs.kde.org/show_bug.cgi?id=159267
>     https://bugs.kde.org/show_bug.cgi?id=192922
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries
> 
> QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.
> 
> 
> Diffs
> -----
> 
>   klipper/generalconfig.ui f513e9c 
>   klipper/historyitem.cpp 36cbe61 
>   klipper/klipper.h 6952b11 
>   klipper/klipper.cpp 798b49f 
>   klipper/klipper.kcfg a03dd16 
> 
> Diff: https://git.reviewboard.kde.org/r/123806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Patrick Eigensatz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150521/af612cb7/attachment.htm>


More information about the kde-core-devel mailing list