[KDE Usability] Review Request 123806: [klipper] Ignore empty / blank entries

[Patrick Eigensatz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80705
-----------------------------------------------------------



klipper/klipper.kcfg (line 24)
<https://git.reviewboard.kde.org/r/123806/#comment55332>

    **Question:** Compiled plasma-workspace using *kdesrc-build --include-dependencies plasma-workspace*, applied patch and compiled again.
    -> Build broken because g++ could not
    locate *klippersettings.h* included in *historyitem.cpp*. Shouldn't this file be generated by *cmake*?
    If I generate *klippersettings{.h,.cpp}* using *kconfig_compiler klipper.kcfg klippersettings.kcfgc* and run *kdesrc* again,
    I get a build error:
    
        CMakeFiles/testHistory.dir/__/historyitem.cpp.o: In function `KlipperSettings::allowWhitespaceEntries()':
        /home/patrick/kdesrc/plasma-workspace/klipper/klippersettings.h:72: undefined reference to `KlipperSettings::self()'
    
    Note: The whole file is full of *return self()->member*, I don't know why it fails on line 72 if it worked
    the for last 20 members. (I didn't change anything, original kconfig_compiler output)


- Patrick Eigensatz


On Mai 21, 2015, 5 nachm., Patrick Eigensatz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123806/
> -----------------------------------------------------------
> 
> (Updated Mai 21, 2015, 5 nachm.)
> 
> 
> Review request for kde-workspace, KDE Usability and Patrick Eigensatz.
> 
> 
> Bugs: 159267 and 192922
>     https://bugs.kde.org/show_bug.cgi?id=159267
>     https://bugs.kde.org/show_bug.cgi?id=192922
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries
> 
> QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.
> 
> 
> Diffs
> -----
> 
>   klipper/generalconfig.ui f513e9c 
>   klipper/historyitem.cpp 36cbe61 
>   klipper/klipper.h 6952b11 
>   klipper/klipper.cpp 798b49f 
>   klipper/klipper.kcfg a03dd16 
> 
> Diff: https://git.reviewboard.kde.org/r/123806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Patrick Eigensatz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150521/fdecb80c/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability